search

ChainSafe / lodestar

🌟 TypeScript Implementation of Ethereum Consensus
https://lodestar.chainsafe.io
Apache License 2.0
1.19k stars 300 forks source link

Move fetch into utils #6505

Open jeluard opened 9 months ago

jeluard commented 9 months ago

Migrate fetch into the utils package. All references should be updated accordingly.

tests will have to be migrated too. Consider that tests requiring a web browser won't be able to run in browser environments.

wemeetagain commented 1 month ago

@nflaig Is this still a good idea? is the idea that we would use the wrapped fetch across the whole monorepo?

nflaig commented 1 month ago

is the idea that we would use the wrapped fetch across the whole monorepo?

we already do, there is a biomjs rule to prevent using the global directly, I am not sure what was the reason to move it to utils package I guess related to https://github.com/ChainSafe/lodestar/issues/6488 that we wanna remove got and utils is a dependency of basically all packages while the api package is not.