Closed nflaig closed 3 months ago
✔️ no performance regression detected
by benchmarkbot/action
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.76%. Comparing base (
3be656b
) to head (962f5dd
). Report is 1 commits behind head on unstable.
Is there anymore endpoint that requires similar treatment?
Any POST endpoint that takes an array as filter, we might wanna apply the same to rewards endpoints
Also noticed validation is too strict for rewards routes (see https://github.com/ChainSafe/lodestar/pull/6881), I think we should also update those and ignore empty []
. This is generally better UX and avoids some edge cases, and there is really never the case where a user would want to call this, apply a empty filter and always get no data.
:tada: This PR is included in v1.20.0 :tada:
Motivation
Similar to https://github.com/ChainSafe/lodestar/pull/6876, and further clarified in https://github.com/ethereum/beacon-APIs/pull/453
Description
Ignore empty array when filtering validator balances