Closed nflaig closed 1 week ago
Attention: Patch coverage is 73.17073%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 62.75%. Comparing base (
f29a6db
) to head (cce03cd
).
✔️ no performance regression detected
by benchmarkbot/action
Motivation
Noticed method invocation calls are part of try-catch for parsing, in the case the server throws any non-
ApiError
it would still result in a 400 response which is not desired as this status code would indicate a client issue while if we throwError
on the server it indicates some internal issue and should be a 500 response.This also simplifies the server handler a bit and better separates parsing from method invocation.
Description
Move server api method invocation out of try-catch for parsing