Closed g11tech closed 2 months ago
✔️ no performance regression detected
by benchmarkbot/action
Attention: Patch coverage is 50.16706%
with 1044 lines
in your changes missing coverage. Please review.
Project coverage is 49.37%. Comparing base (
5d2e1a7
) to head (03f7396
). Report is 77 commits behind head on unstable.
e2e consistently failed in https://github.com/ChainSafe/lodestar/actions/runs/10518956587/job/29145618824?pr=7043
one error I see in proposerBoostReorg.test.ts
is
Eph 1/5 0.028[vc-0-VAL-0-7] error: Error publishing attestations slot=13 - submitPoolAttestations failed with status 500: Cannot read properties of undefined (reading 'submitPoolAttestationsV2')
Error: submitPoolAttestations failed with status 500: Cannot read properties of undefined (reading 'submitPoolAttestationsV2')
at ApiResponse.apiResponse.error (/Users/tuyennguyen/Projects/lodestar/packages/beacon-node/test/utils/node/validator.ts:111:20)
at ApiResponse.assertOk (/Users/tuyennguyen/Projects/lodestar/packages/api/src/utils/client/response.ts:155:18)
at AttestationService.signAndPublishAttestations (/Users/tuyennguyen/Projects/lodestar/packages/validator/src/services/attestation.ts:243:78)
at AttestationService.runAttestationTasksGrouped (/Users/tuyennguyen/Projects/lodestar/packages/validator/src/services/attestation.ts:155:5)
at AttestationService.runAttestationTasks (/Users/tuyennguyen/Projects/lodestar/packages/validator/src/services/attestation.ts:117:9)
at Clock.runAtMostEvery (/Users/tuyennguyen/Projects/lodestar/packages/validator/src/util/clock.ts:96:7)
cc @nflaig @ensi321
I deployed #7043 to beta, metrics look good to me, all are comparable to unstable
:tada: This PR is included in v1.22.0 :tada:
superseeding previous rebase :
superceeds :