ChainSafe / lodestar

🌟 TypeScript Implementation of Ethereum Consensus
https://lodestar.chainsafe.io
Apache License 2.0
1.15k stars 283 forks source link

feat: standardized peerdas metrics #7095

Open matthewkeil opened 1 week ago

matthewkeil commented 1 week ago

Motivation

Pari requested that these standardized metrics be added to Lodestar. Once matrix reconstruction is implemented, will implement the metrics in that function, added them to the metrics object for now though so they are available in that PR.

https://discord.com/channels/595666850260713488/1252403418941624532/1285889840746856498

nflaig commented 1 week ago

There is a PR related to this https://github.com/ethereum/beacon-metrics/pull/13

matthewkeil commented 1 week ago

There is a PR related to this ethereum/beacon-metrics#13

Sweet. Ill read that more deeply. Looks like the branch I got these from is the one being merged in. Got it from Pari at ethpandops was looking for here: https://github.com/KatyaRyazantseva/beacon-metrics/blob/master/metrics.md#peerdas-metrics

Ill add the couple for gossip and what not

matthewkeil commented 1 week ago

The spec is still being hammered out so some of the metric names may change.

https://github.com/ethereum/beacon-metrics/pull/13

Will keep this PR open and update accordingly.

matthewkeil commented 1 week ago

Some of the metric were added in the gossipsub package here https://github.com/ChainSafe/js-libp2p-gossipsub/pull/508