ChainSafe / metamask-snap-polkadot

Metamask plugin for interacting with Polkadot dapps and other Substrate based chains.
Apache License 2.0
84 stars 61 forks source link

chore(deps): update tj-actions/verify-changed-files action to v10 [security] - autoclosed #218

Closed renovate[bot] closed 8 months ago

renovate[bot] commented 8 months ago

Mend Renovate

This PR contains the following updates:

Package Type Update Change
tj-actions/verify-changed-files action major v9 -> v10

GitHub Vulnerability Alerts

CVE-2023-52137

Summary

The tj-actions/verify-changed-files action allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets.

Details

The verify-changed-files workflow returns the list of files changed within a workflow execution.

This could potentially allow filenames that contain special characters such as ; and ` (backtick) which can be used by an attacker to take over the GitHub Runner if the output value is used in a raw fashion (thus being directly replaced before execution) inside a run block. By running custom commands an attacker may be able to steal secrets such as GITHUB_TOKEN if triggered on other events than pull_request. For example on push.

Proof of Concept

  1. Submit a pull request to the repository with a new file injecting a command. For example $(whoami).txt would be a valid filename.
  2. Upon approval of the workflow (triggered by the pull request), the action will get executed and the malicious pull request filename will flow into the List all changed files tracked and untracked files step.
- name: List all changed files tracked and untracked files
  run: |
    echo "Changed files: $"

Example output:


##[group]Run echo "Changed files: $(whoami).txt"
  echo "Changed files: $(whoami).txt"
shell: /usr/bin/bash -e {0}

##[endgroup]
Changed files: runner.txt

Impact

This issue may lead to arbitrary command execution in the GitHub Runner.

Resolution

- name: List all changed files tracked and untracked files
  env:
     CHANGED_FILES: $
  run: |
    echo "Changed files: $CHANGED_FILES"

Resources


Release Notes

tj-actions/verify-changed-files (tj-actions/verify-changed-files) ### [`v10`](https://togithub.com/tj-actions/verify-changed-files/releases/tag/v10) [Compare Source](https://togithub.com/tj-actions/verify-changed-files/compare/v9...v10) #### 🔥 🔥 BREAKING CHANGES 🔥 🔥 - feat: add support for detecting deleted files by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/181](https://togithub.com/tj-actions/verify-changed-files/pull/181) #### What's Changed - Upgraded to v9.2 by [@​jackton1](https://togithub.com/jackton1) in [https://github.com/tj-actions/verify-changed-files/pull/178](https://togithub.com/tj-actions/verify-changed-files/pull/178) - chore(deps): update codacy/codacy-analysis-cli-action action to v4.1.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/tj-actions/verify-changed-files/pull/179](https://togithub.com/tj-actions/verify-changed-files/pull/179) **Full Changelog**: https://github.com/tj-actions/verify-changed-files/compare/v9.2...v10

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.