search

ChainSafe / sprinter-ts

1 stars 0 forks source link

chore: recolor POC #43

Closed BeroBurny closed 2 months ago

BeroBurny commented 2 months ago

minor quips:

  • balances with 0 get displayed as 0.— it doesn’t look as nice but 🤷

  • is there any way to treat the display of Total Balance of USDC and ETH as separate? the way it is displayed currently makes it look like the ETH amt is worth the displayed USDC amt.

    • would suggest line break, one line delineating USDC (even better if it can be the logo) and another line delineating ETH (even better if it can be the logo)

related note: i guess also… isn’t the table reflecting the exact same information repeated with the big bolded numbers/balances? why even have that line then? 🤔

  1. solved
  2. its a tricky one if you put it under, it can cause the same effect - but if you have eth and weth will be under eth number, in first version we had usdc and usdt and dai, and total value is sum of values
haochizzle commented 2 months ago

minor quips:

  • balances with 0 get displayed as 0.— it doesn’t look as nice but 🤷

  • is there any way to treat the display of Total Balance of USDC and ETH as separate? the way it is displayed currently makes it look like the ETH amt is worth the displayed USDC amt.

    • would suggest line break, one line delineating USDC (even better if it can be the logo) and another line delineating ETH (even better if it can be the logo)

related note: i guess also… isn’t the table reflecting the exact same information repeated with the big bolded numbers/balances? why even have that line then? 🤔

  1. solved
  2. its a tricky one if you put it under, it can cause the same effect - but if you have eth and weth will be under eth number, in first version we had usdc and usdt and dai, and total value is sum of values

perhaps a question worth sharing with @serenaho. i know this is just a POC but if this is going on display publicly i would lean towards doing it somewhat properly - and so i can do a proper video for it as well!