feat/snapshot-eip-4881 - Githubissues

AkshatGada commented 1 month ago

Attempts to solve issue https://github.com/ChainSafe/lodestar/issues/4935

Added deposit contract snapshot interface
Added test cases

waiting for your review

CLAassistant commented 1 month ago

All committers have signed the CLA.

CLAassistant commented 1 month ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

philknows commented 1 month ago

If you were trying to commit your work from here, it did not make it into this PR...

AkshatGada commented 1 month ago

Thanks so much for your feedback , I will start resolving the linting errors and also start to run successfully tests . Regards , Akshat

On Fri, Jun 14, 2024, 7:29 PM Cayman @.***> wrote:

@.**** commented on this pull request.

Looks like a good start. A few comments:

Instead of redefining MerkleTree, Leaf, Node, etc here, please reuse the existing infra from this library. That means using the existing Tree, LeafNode, BranchNode constructs. You should be able to define your custom tree editing / navigation functions either purely functionally, or in a wrapper class.

Eventually, this code / PR should be migrated to the lodestar repo and live there. Whether you want to keep this review here for now is up to you.

— Reply to this email directly, view it on GitHub https://github.com/ChainSafe/ssz/pull/377#pullrequestreview-2118467984, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDLB6TCYRZXENTGTDUAJHDZHLZKVAVCNFSM6AAAAABJCDVGMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJYGQ3DOOJYGQ . You are receiving this because you authored the thread.Message ID: @.***>

philknows commented 1 week ago

Hi @AkshatGada , do you still plan to keep working on this?

AkshatGada commented 1 week ago

Yes , I am a little busy with college and my internship , I am running tests locally , please grant me some time to get it done .

AkshatGada commented 1 week ago

I am planning to do it as a project for the ethereum protocol fellowship.

ChainSafe / ssz

feat/snapshot-eip-4881 #377