Chainfire / HoleyLight

Notification LED for Samsung/Pixel phones with in-screen camera cut-out (punch-hole)
Other
176 stars 36 forks source link

App doesn't seem to be maintained anymore. #111

Open jayb-g opened 1 year ago

jayb-g commented 1 year ago

I was looking for an open source alternative for aod notify and found this app, aptly and cleverly named holey light.!

Although I'm not fully sure if it still works as intended since last commits and apks are from around a year ago. Besides the app is not on f-droid nor it has releases listed on github so that people like me using Obtainium could install and keep track of it to update when new version is released. The apks are weirdly kept in apk folder and ther's also aod helper which needs to be installed. Can't it be made into one package?

Also many of the issues seem to be unanswered and fixes for pixel pending since a year. Maybe not enough contributors?

Anyway I think the app is really good and much needed by many, so the purpose of this issue is to know status of the project and future roadmap.

Thanks

d7415 commented 1 year ago

and ther's also aod helper which needs to be installed. Can't it be made into one package?

This functionality cannot be built directly into the main app due to both Android technical limitations and the relevant code violating Google Play policy.

https://github.com/Chainfire/HoleyLight/blob/master/apks/AODHelper.md

Chainfire commented 1 year ago

I no longer concern myself with developing for Android, most of my stuff is already gone from the Play Store, and soon the remainder will follow. I cannot be bothered jumping through Google's hoops or dealing with their BS anymore. And I've dealt with enough griefing from the Android community that I don't do it for them either. Simply put, I have better things to do.

As for f-droid, Obtanium, and any other channel of publishing, requests, demand, etc, same difference. You get the source and even a build, if you have more demands, kindly forward them to /dev/null.

That being said, this app predates aodNotify, and I use this app every day, so anytime my phone gets updated (or upgraded) I will fix the app for it. The Pixel stuff came at a time where updates conflicted, and I do not have the will or ability to merge (and then extensively test) the changes. Now that I think about it, I might not have even pushed the latest version, which is 1.02 and available on both Telegram and XDA. I know it will break for older users, so...

So essentially, this app (and everything else I ever made) is EOL. But if you use the same phones I do there will be working versions for quite some time I believe :)

Regarding AOD Helper: personally I don't even have it installed on my S21 Ultra. I feel it works well enough without it. And as I like having the AOD clock visible even when there's no notifications, there's not really a point to installing AOD Helper (aside from slightly faster screen updates on notifications... meh). Either way, Google has blocked things AOD Helper does on modern apps, that it even still works is a loophole in newer Android versions, they cannot be combined.

jayb-g commented 1 year ago

Well, good luck. Maybe someone else would fork it and continue development

lemeurherve commented 1 year ago

Thanks for the update!

NicNamSam commented 7 months ago

This is a real shame since this is THE best app for this purpose. All others are more limited. Even the full versions that cost money are more limited than this app. It's frustrating that Samsung doesn't have a built-in notification light function and that there is only one good third-party alternative that I've been able to find and it has been abandoned.