Chainlit / chainlit

Build Conversational AI in minutes ⚡️
https://docs.chainlit.io
Apache License 2.0
6.73k stars 873 forks source link

Poetry lockfile should not be ignored #1190

Closed dokterbob closed 2 weeks ago

dokterbob commented 1 month ago

For some reason, both poetry lock files are not committed to the repo.

This causes unpredictable builds and is explicitly against best practices, see: https://python-poetry.org/docs/basic-usage/#committing-your-poetrylock-file-to-version-control

Note also: "If you do not want to give up the reproducibility and performance benefits, consider a regular refresh of poetry.lock to stay up-to-date and reduce the risk of sudden breakage for users."

As a bonus, this will also make poetry install run way faster.

Specifically, the following should be removed from .gitignore:

Possibly related: #1189

dokterbob commented 1 month ago

Suggestion: https://github.com/marketplace/actions/update-python-poetry-packages