Chainlit / chainlit

Build Conversational AI in minutes ⚡️
https://docs.chainlit.io
Apache License 2.0
7.13k stars 935 forks source link

Issue with error checking in config file (project_id) #86

Closed jimmarshall87 closed 1 year ago

jimmarshall87 commented 1 year ago

I might be wrong, but shouldn't:

if not project_settings.public and not project_settings.project_id:

...be:

if not project_settings.public and not project_settings.id:

in config.py?

I think this may have broken in 0.4.0

willydouhard commented 1 year ago

Nice catch, will be fixed in the next release!

jimmarshall87 commented 1 year ago

Great, now I got one right I will PR the next one I find for you....!

willydouhard commented 1 year ago

Awesome, you can follow here https://github.com/Chainlit/chainlit/pull/88