search

ChaitanyaKaranam / servicenow-rest-api

Node.js Wrapper library for ServiceNow REST API.
https://www.npmjs.com/package/servicenow-rest-api
MIT License
18 stars 21 forks source link

feature: Adding getChangeTasks for Change_request #20

Closed xmariopereira closed 3 years ago

xmariopereira commented 3 years ago

When a change_request is created, sometimes change_task is added. So I have added the option to get Change_task from change_request.

ChaitanyaKaranam commented 3 years ago

When a change_request is created, sometimes change_task is added. So I have added the option to get Change_task from change_request.

Thanks for the PR.. will check it soon

xmariopereira commented 3 years ago

Hi @ChaitanyaKaranam,

Still waiting for the approval :)

By the way, did you ever thinking to move this to async?

ChaitanyaKaranam commented 3 years ago

Hi @ChaitanyaKaranam,

Still waiting for the approval :)

By the way, did you ever thinking to move this to async?

Sorry for the delay. I'm creating an instance to review this.

Yes.. I was considering promisifying these functions.. there are bunch of other stuff that I want to add. Probably will add a roadmap with detailed info.

xmariopereira commented 3 years ago

@ChaitanyaKaranam readme was fixed

xmariopereira commented 3 years ago

by the way, if you add a roadmap i maybe wanna help :) I was going to fork and create an async version. But if you want i can commit to this codebase

ChaitanyaKaranam commented 3 years ago

by the way, if you add a roadmap i maybe wanna help :) I was going to fork and create an async version. But if you want i can commit to this codebase

Awesome.. Will make sure to include you in the conversation.

xmariopereira commented 3 years ago

nice!! don't forget to do a new version release! :)