search

ChaitanyaKaranam / servicenow-rest-api

Node.js Wrapper library for ServiceNow REST API.
https://www.npmjs.com/package/servicenow-rest-api
MIT License
18 stars 21 forks source link

Treat the instance as a domain name if it contains dot. #9

Closed chovanecm closed 4 years ago

chovanecm commented 4 years ago

This should resolve my issue #8 while keeping backwards compatibility. Would you accept the PR?

chovanecm commented 4 years ago

Note, this change affects PR #7 as well, which adds a new method that is using the original instance URL resolution

ChaitanyaKaranam commented 4 years ago

@chovanecm Apologies for the delay on this. I will review this shortly.

ChaitanyaKaranam commented 4 years ago

@chovanecm This looks good. Thanks for the PR 👍