search

Chakroun-Anas / turbo-console-log

591 stars 141 forks source link

Feature request: logMessageSuffix #128

Closed mariaedwards closed 1 year ago

mariaedwards commented 3 years ago

Could you please add a new property logMessageSuffix and default it to :? So when console.log is added it will be 

🟣 ~ file: app.js ~ line 6 ~ second: Second file

instead of:

🟣 ~ file: app.js ~ line 6 ~ second Second file
tfreitas90 commented 1 year ago

This would be nice....

besnikkorca commented 1 year ago

Added PR that should allow this @mariaedwards @tfreitas90

farhadh commented 1 year ago

Hey!

I have added the PR for this feature for the most recent refactored code :)

I hope @Chakroun-Anas would confirm and merge it <3. I too would like to have this feature so badly :)

Chakroun-Anas commented 1 year ago

Hello Farhad,

Thank you for your contribution, did check that all the tests pass ? ^^

Cordially,

De : Farhad H. P. Shirvan @.> Envoyé : samedi 21 janvier 2023 15:21 À : Chakroun-Anas/turbo-console-log @.> Cc : Chakroun Anas @.>; Mention @.> Objet : Re: [Chakroun-Anas/turbo-console-log] Feature request: logMessageSuffix (#128)

Hey!

I have added the PRhttps://github.com/Chakroun-Anas/turbo-console-log/pull/190 for this feature for the most recent refactored code :)

I hope @Chakroun-Anashttps://github.com/Chakroun-Anas would confirm and merge it <3. I too would like to have this feature so badly :)

— Reply to this email directly, view it on GitHubhttps://github.com/Chakroun-Anas/turbo-console-log/issues/128#issuecomment-1399260731, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIRYHC2CS6OWJBYUSDBWD3TWTPWIHANCNFSM42V3BNTQ. You are receiving this because you were mentioned.Message ID: @.***>

farhadh commented 1 year ago

Hi @Chakroun-Anas!

My pleasure. Yes. All tests, as shown below, were passed for my 3 PRs (#190, #191, and #192) which are on top of each other :)



Completed initializing default profile extensions in extensions installation folder. file:///home/farhad/.vscode/extensions

Loading development extension at /home/farhad/turbo/turbo-console-log

  ✓ Insert log message related to a class constructor param (3636ms)

  ✓ Insert log message related to a class function param (738ms)

  ✓ Insert log message related to a function parameter within a class function (654ms)

  ✓ Insert log message related to a deconstructred property assigned to a variable (977ms)

  ✓ Insert log message related to a multiline function parameter  (2072ms)

  ✓ Insert log message related to a function parameter (546ms)

[main 2023-01-22T16:55:31.807Z] update#setState checking for updates

[main 2023-01-22T16:55:31.908Z] update#setState idle

  ✓ Insert log message in the context of a function with a bunch of decorators (515ms)

  ✓ Determine the closing brace line num (286ms)

  ✓ Insert log message in the last line of the file (451ms)

  ✓ Insert log message related to an object variable (350ms)

  ✓ Insert log message related to an object function call (532ms)

  ✓ Obj function call no variable assignment (287ms)

  ✓ Object variable with a declared type (545ms)

  ✓ Insert log message related to a function (which params are defined in one line) param (312ms)

  ✓ Insert log message related to a primitive variable (402ms)

  ✓ Insert log message related to a variable declared in a promise callback (477ms)

  d

    Single line

      ✓ Assigned to a variable

      ✓ Parameter of a function

      ✓ Chained call

    Multiple lines

      ✓ Example 01

      ✓ Example 02

      ✓ Example 03

      ✓ Example 04

  Empty functions

    ✓ Example 01

    ✓ Example 02

  Insert log message related to a variable with a function as the value

    ✓ Example 01

    ✓ Example 02

    ✓ Example 03

  JS Line Code Processing

    ✓ Assignment of object literal to a variable

    ✓ Assignment of an array to a variable

    Classes

      ✓ Check class declaration

      ✓ Get class name

    Functions
      ✓ Check built in function invocation

      ✓ Check named function Declaration

      ✓ Get function name

      ✓ Assignment of function to a variable

      ✓ Check object function call

      ✓ Anonymous functions

      ✓ Arugment of anonymous function

      ✓ Should transform anonymous function

[main 2023-01-22T16:55:56.039Z] Extension host with pid 7170 exited with code: 0, signal: null.

Exit code:   0
Done

Waiting for the debugger to disconnect...
Waiting for the debugger to disconnect...
Chakroun-Anas commented 1 year ago

Hello Farhad,

Do you have some time to talk this weekend ?

Thx

De : Anas Chakroun @.> Envoyé : dimanche 22 janvier 2023 16:52 À : Chakroun-Anas/turbo-console-log @.> Objet : RE: [Chakroun-Anas/turbo-console-log] Feature request: logMessageSuffix (#128)

Hello Farhad,

Thank you for your contribution, did check that all the tests pass ? ^^

Cordially,

De : Farhad H. P. Shirvan @.> Envoyé : samedi 21 janvier 2023 15:21 À : Chakroun-Anas/turbo-console-log @.> Cc : Chakroun Anas @.>; Mention @.> Objet : Re: [Chakroun-Anas/turbo-console-log] Feature request: logMessageSuffix (#128)

Hey!

I have added the PRhttps://github.com/Chakroun-Anas/turbo-console-log/pull/190 for this feature for the most recent refactored code :)

I hope @Chakroun-Anashttps://github.com/Chakroun-Anas would confirm and merge it <3. I too would like to have this feature so badly :)

— Reply to this email directly, view it on GitHubhttps://github.com/Chakroun-Anas/turbo-console-log/issues/128#issuecomment-1399260731, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIRYHC2CS6OWJBYUSDBWD3TWTPWIHANCNFSM42V3BNTQ. You are receiving this because you were mentioned.Message ID: @.***>

farhadh commented 1 year ago

Hi @Chakroun-Anas!

Yes. Just let me know when :)

Chakroun-Anas commented 1 year ago

Hello,

So sorry, i barely find some time, where are you from i may to ask?

Cordially,

De : Farhad H. P. Shirvan @.> Envoyé : samedi 28 janvier 2023 11:58 À : Chakroun-Anas/turbo-console-log @.> Cc : Chakroun Anas @.>; Mention @.> Objet : Re: [Chakroun-Anas/turbo-console-log] Feature request: logMessageSuffix (#128)

Hi @Chakroun-Anashttps://github.com/Chakroun-Anas!

Yes. Just let me know when :)

— Reply to this email directly, view it on GitHubhttps://github.com/Chakroun-Anas/turbo-console-log/issues/128#issuecomment-1407373532, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIRYHCZMBZPPFIFBEKPA7Z3WUT3TVANCNFSM42V3BNTQ. You are receiving this because you were mentioned.Message ID: @.***>

farhadh commented 1 year ago

It's ok, @Chakroun-Anas. Why though? :)) You can see it in my profile ;)

Chakroun-Anas commented 1 year ago

Hello,

What do you think about creating a slack channel for the extension so that we can communicate more efficiently, i need to talk to you before getting to collaborate please ^^

Thx

De : Farhad H. P. Shirvan @.> Envoyé : mardi 31 janvier 2023 12:10 À : Chakroun-Anas/turbo-console-log @.> Cc : Chakroun Anas @.>; Mention @.> Objet : Re: [Chakroun-Anas/turbo-console-log] Feature request: logMessageSuffix (#128)

It's ok, @Chakroun-Anashttps://github.com/Chakroun-Anas. Why though? :)) You can see it in my profile ;)

— Reply to this email directly, view it on GitHubhttps://github.com/Chakroun-Anas/turbo-console-log/issues/128#issuecomment-1410169199, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIRYHC5VKI7GXRGNSQLQXN3WVDXLNANCNFSM42V3BNTQ. You are receiving this because you were mentioned.Message ID: @.***>

farhadh commented 1 year ago

@Chakroun-Anas OK. Would you mind creating the Slack channel and letting me know about it? :)

Chakroun-Anas commented 1 year ago

Hello,

I created the channel 🙂

I need your email so that i can invite you and get back to work 😉

Thx,

De : Farhad H. P. Shirvan @.> Envoyé : vendredi 3 février 2023 11:34 À : Chakroun-Anas/turbo-console-log @.> Cc : Chakroun Anas @.>; Mention @.> Objet : Re: [Chakroun-Anas/turbo-console-log] Feature request: logMessageSuffix (#128)

@Chakroun-Anashttps://github.com/Chakroun-Anas OK. Would you mind creating the Slack channel and letting me know about it? :)

— Reply to this email directly, view it on GitHubhttps://github.com/Chakroun-Anas/turbo-console-log/issues/128#issuecomment-1415656961, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIRYHC4QJ4IW2BLGXLCBEUTWVTNMLANCNFSM42V3BNTQ. You are receiving this because you were mentioned.Message ID: @.***>

farhadh commented 1 year ago

@Chakroun-Anas I sent you and email :)

Chakroun-Anas commented 1 year ago

Hello guys,

Done by @farhadh , thank you so much for your efforts ^^