Added 'is' to make palindrome more self-explanatory

Chalarangelo / 30-seconds-of-python

Short Python code snippets for all your development needs

https://www.30secondsofcode.org/python/p/1

Creative Commons Attribution 4.0 International

8.83k stars 1.26k forks source link

Added 'is' to make palindrome more self-explanatory #374

Closed weydaej closed 4 years ago

weydaej commented 4 years ago

Okay, fair to not merge it but why make it invalid? I felt it was a good change since functions that return booleans typically start with "is".

Chalarangelo commented 4 years ago

Because changes to the API of methods (footprint, naming etc) must serve an actual purpose. Also, we invalidate PRs that should be excluded from future searches when we are looking for information, as they just clutter up the issue tracker. Cheers.

weydaej commented 4 years ago

Just for argument's sake, when looking at your list it seems that boolean functions all start with "is_" such as is_anagram, is_contained_in, is_divisible, is_even, is_odd and is_prime. The reason I felt is_palindrome would be a useful change is because of the "follow existing conventions as seen in other snippets" mentioned in your CONTRIBUTING.md.

contributing