search

Chalarangelo / furl

Functional react.js components.
https://furl.netlify.com/
MIT License
34 stars 2 forks source link

SVGs shrink based on screen size when part of a Grid #38

Closed Chalarangelo closed 5 years ago

Chalarangelo commented 5 years ago

Consider the following component tree:

<Grid>
  <Row>
    <Column size={3}>
      <Button>
        <Icon name='github' height={18} width={18}/>
      </Button>
    </Column>
  </Row>
</Grid>

In the above example the Icon component will shrink proportionately to the screen size, as the Column is resized and its max-width, set in _Reset.scss, updates automatically.

This is a very annoying bug and it requires a fix and re-evaluation of the related CSS ruleset.

Chalarangelo commented 5 years ago

The bug does not come from combining SVG with Grid. In fact, it comes from the responsiveness of images. A minimum size, at least for icons, could help a little bit.