ChalkyBrush / roshpit-bug-tracker

8 stars 0 forks source link

Voltex E1 illusion base attack damage calculation ignores presence of ALL attack damage bonus effects #1609

Closed DeckardCainRPC closed 3 years ago

DeckardCainRPC commented 3 years ago

[8:19 PM] Stonejaw: voltex w2 doesnt apply pre summon for e1 [8:19 PM] Mandelbrot: The guy is playing with an e1 pa builds, but having trouble making it function properly [8:20 PM] Deckard Cain: what the christ [8:20 PM] Mandelbrot: I haven't touched that shit, nor played it after 4.0 so i can't help much [8:20 PM] Deckard Cain: okay so let me make sure i understand what's going on

  1. you cast W, which gives you W2's attack damage bonus
  2. you cast E, spawning an illusion
  3. you observe that the illusion's base attack damage is calculated as though W2 had not been applied at all?

[8:21 PM] Stonejaw: yep

DeckardCainRPC commented 3 years ago

[8:48 PM] Deckard Cain: i also went one step further and confirmed that illusions are being spawned with base attack damage values that ignore ALL bonus (green) attack damage on voltex [8:48 PM] Deckard Cain: i spawned in some voyager boots and put them on, and set a sapphire in them [8:49 PM] Deckard Cain: even with this item doing its job and granting its high bonus attack power, illusions were still being spawned with 420% of voltex's base attack damage, ignoring the bonus damage entirely [8:49 PM] Deckard Cain: so i can conclusively tell you that e1 is bugged [8:49 PM] Deckard Cain: and by "bugged' i mean "probably redledcat used the wrong GetAttackerWhatever variable" [8:50 PM] Deckard Cain: i will add this to the bugtracker and now my work here is most assuredly done

redledcat commented 3 years ago

I think it's very logical: W2 would double dip for illusions in other way, applying both bonus damage for heroes and bonus damage for allies parts to damage calculations

redledcat commented 3 years ago

moreover, many summons in 4.0 and later which use exact same function called AdjustSummon it takes caster's HP, Armors, Pierces, level and attack damage if needed, and attack damage used here follows the rule it only takes base attack damage, not full attack power. List of summons to never adress this issue anymore if anyone will wonder why it doesn't calculate like they assume: Jex - fire treant and both thunder saplings sorc - e2 water elemental Conjuror - R elemental deity Voltex - e1 illusion Ekkan - e2 familiar Items: scourge helm, tome of chaos, thorok, robe of flooding, alien armor's illusion, zombiegrip gauntlet, mortuary charm, wolfir, erudite teacher robes, boneguard gauntlets, terrasic lava boots

DeckardCainRPC commented 3 years ago

alright, completely understandable, i agree that double dipping is a significant balance issue.

here is what i want, then: for all of these effects which use AdjustSummon, make sure that their tooltips use the exact phrase "base attack damage" instead of "total attack damage" when describing how the summoned unit's stats are calculated. if you want me to do this then let me know

redledcat commented 3 years ago

next patch everything explained correctly, except mortuary charm because I don't want to check it right now others were like every summon item and familiar scaling off attack damage in game. Ekkan e2, voltex e1, conjuror R arcana, robe of flooding, boneguard, tome of chaos, scourge knight, thorok, zombiegrip, erudite teacher, alien armor, terrasic lava boots, wolfir