search

ChalkyBrush / roshpit-bug-tracker

8 stars 0 forks source link

Hand of Midas new Ruby effect does not actually increase proc chance #1611

Closed DeckardCainRPC closed 3 years ago

DeckardCainRPC commented 3 years ago

STEPS TO REPRODUCE:

  1. put it on
  2. put a perfect ruby in it
  3. go to the target dummy
  4. attack it repeatedly
  5. observe that it now deals physical damage, as advertised, but its proc chance is still 20%

SUGGESTED COURSE OF ACTION:

  1. fix that
  2. replace ruby tooltip with "Midas Touch now deals Physical damage, pierces Spell Immunity, and has a @ruby_property1% chance to activate."
redledcat commented 3 years ago

It doesn't grant any improvements to proc rate, it just replaces magical midas damage with physical with said chance perfect ruby makes it always physical, pristine makes 4 procs out of 5 physical and 5th is still magical

DeckardCainRPC commented 3 years ago

ohhhhhhhhhhhhhhhh okay, i got it

then replace ruby tooltip with "When Midas Touch effect triggers, it has a @ruby_property1% chance to pierce Spell Immunity and deal Physical damage instead of Magical"

redledcat commented 3 years ago

fixed next patch