search

Challengermode / CoreRcon

A .NET Standard implementation of the Source RCON Protocol.
MIT License
70 stars 12 forks source link

PR, Palworld Support (Tested on Minecraft and PalWorld) #57

Closed ExusAltimus closed 7 months ago

ExusAltimus commented 7 months ago

Fixes https://github.com/Challengermode/CoreRcon/issues/56

Updated the RCONPacket to use gorcon's implementation (https://github.com/gorcon/rcon/blob/master/packet.go). This fixed the issues I was having with authentication, I suppose it should work with other servers since gorcon claims support with several.

Also added a parameter to RCON called strictCommandPacketIdMatching (default: true) which when enabled matches the command to the response packet (This was the existing behavior).

When set to false the command instead behaves as a queue and any response will complete the command taskSource. This is because PalWorld always returns 0 for the response packet id (bad).

ExusAltimus commented 7 months ago

Just tested on a MC server just and it works.

image

ExusAltimus commented 7 months ago

Also forgive me but I dont contribute often, what do you mean by "Can merge if your rebase in master"

xobust commented 7 months ago

To make the branch mergeable you need to merge or rebase it with master you can run this command: git pull git@github.com:Challengermode/CoreRcon.git And then solve all conflicts with a merge editor like vscode.

ExusAltimus commented 7 months ago

Thank you, I applied the changes you requested, I also merged changes from main

ExusAltimus commented 7 months ago

I've been successfully using the RCON for palworld for about a week now, palworld auto disconnects the RCON every 20 seconds but autoconnect lets me reuse the same instance without issues

image

Trekkan commented 7 months ago

Can we get this merged? Thanks for everyone's work!

xobust commented 7 months ago

Hey sorry for the delay the new version should be up shortly. Thanks for your contribution :) https://www.nuget.org/packages/CoreRCON/5.4.0