search

Chalos-Atiesh / GuildTradeskills

Other
2 stars 3 forks source link

Add french localization Chalos-Atiesh/GuildTradeskills #58

Closed Herdawyn closed 4 years ago

Herdawyn commented 4 years ago

Based on german localization file

i'm not sure of these value: L['ONLINE'] = ONLINE L['OFFLINE'] = OFFLINE

how could I test my file?

luitzifa commented 4 years ago

You need to add your file to the filelist in GuildTradeskills.toc The variable ONLINE and OFFLINE are defined locally in lines 13/14, so dont change line 321/322.

Edit: After editing the toc file, you should see your translation in french client.

Chalos-Atiesh commented 4 years ago

https://github.com/Chalos-Atiesh/GuildTradeskills/pull/58

Chalos-Atiesh commented 4 years ago

Thanks for adding this! It's much appreciated.

I'm not sure if this is correct (got it from Google translate) but you'll want to change lines 13 and 14 to something like: local ONLINE = 'En ligne' local OFFLINE = 'Hors ligne'

Please add this line to the GuildTradeskills.toc Locale\localization.fr.lua

Herdawyn commented 4 years ago

Glad to help.

You also have https://www.deepl.com/fr/translator which gives good translation. The translation is good but does it have to match Blizzard's?

Chalos-Atiesh commented 4 years ago

It uses Blizzard's translation to maintain whether friends and guildmates are online/offline without performing another character query so yes. It needs to match exactly.

I was doing some spot checking (just to make sure there were no curse words) and wasn't able to find a translation for 'Whou pinaise'. Could you update it to be a bit more formal?

I thought about using translation websites but decided against it as they frequently provide some... odd output and there's no way I'd be able to know it was odd.

Herdawyn commented 4 years ago

That's a "The Simpsons" easter egg in french. I changed it to something more formal but it's a bit tricky because formal is not really used anymore and sounds a bit posh or silly, I think I found something neutral.

Where can I find the blizzard translation? On my guild panel online members are seen as "En ligne" but offline just show the time since last login, for friends it shows "inconnu" ie "unknown".

Also note that I changed the first boolean of this line to false like for the german version: local L = LibStub('AceLocale-3.0'):NewLocale(AddOnName, 'frFR', false, true)

I have added my caracters profession and looking for a member of my guild to make tests with me.

Chalos-Atiesh commented 4 years ago

Here's a list of global strings. It looks like they use: ERR_FRIEND_OFFLINE_S = "%s vient de se déconnecter."; ERR_FRIEND_ONLINE_SS = "|Hplayer:%s|h[%s]|h vient de se connecter."; https://www.townlong-yak.com/framexml/34972/GlobalStrings.lua/FR

And apologies for earlier. I was mistaken. The addon previously used it to determine that but does not appear to do so now. So it does not have to match exactly.