search

Chalos-Atiesh / GuildTradeskills

Other
2 stars 3 forks source link

German and French Localization not working on Enchanting #71

Closed scholaly closed 4 years ago

scholaly commented 4 years ago

See Profession.lua Line 146:

    if profession.professionName == 'Enchanting' then
        GetNumTradeSkills = GetNumCrafts
        GetTradeSkillItemLink = GetCraftItemLink
        GetTradeSkillNumReagents = GetCraftNumReagents
        GetTradeSkillReagentInfo = GetCraftReagentInfo
        GetTradeSkillReagentItemLink = GetCraftReagentItemLink

        GetTradeSkillInfo = function(i)
            local name, _, kind, num = GetCraftInfo(i)
            return name, kind, num
        end
    end

Hard coded String 'Enchanting' will never be found on german or french client.

Chalos-Atiesh commented 4 years ago

Whoops. That should be localized. I'll have time to get it out in a day or so.

Chalos-Atiesh commented 4 years ago

This should be fixed with 6.0.5: https://github.com/Chalos-Atiesh/GuildTradeskills/commit/d184860d72a60fcb16cda5987c40ce6236cf730c

scholaly commented 4 years ago

It's working fine now. Thanks =)