Chalwk / HALO-SCRIPT-PROJECTS

:white_check_mark: Halo PC|CE - Add-ons for Phasor V2+ and SAPP :new_zealand:
Other
32 stars 13 forks source link

Admin Messages.lua #129

Closed ghost closed 2 years ago

ghost commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

The script was not working until I deleted "i ~= p and " on line 66 and I found an error in line 37, it should be "rcon" instead of "rprint".

Please complete the following information:

Additional context Add any other context about the problem here.

The script works perfectly now after editing the lines mentioned above. I don't know what the issue on line 66 was. I remembered that the script was working in Velocity-Multi-Mod, so I just compared the code from there and tried to make it the same as this one by deleting "i ~= p and " on line 66, surprisingly it worked 😃 Then on line 37 it was a mistype since in the configuration it says that to change the environment you should choose between "chat" and "rcon", this one was fairly simple as I know some coding.

Thanks!

github-actions[bot] commented 3 years ago

Thanks for submitting a ticket. I will respond within 2 business days of submission. Stay tuned.

Chalwk commented 3 years ago

I have reviewed the issues described. Good spotting on the typo. However, the code you removed on line 66:

if (i ~= p and player_present(i)) then

... was not put there by mistake. This line prevents the newly joined Admin from seeing the join message themselves (by design). Anyone who is NOT the admin will see it.

ghost commented 3 years ago

Ohhh so the script was working, I just didn't see it lol

I see, thanks for letting me know xD

Chalwk commented 3 years ago

@mxwk

This script has been refactored for you.

You can see all the changes here.

Click to view the whole script.

New settings:

local Join_Messages = {

    -- Level 1:
    --
    [1] = "[TRIAL-MOD] %name% joined the server. Everybody hide!",

    -- Level 2:
    --
    [2] = "[MODERATOR] %name% ust showed up. Hold my beer!",

    -- Level 3:
    --
    [3] = "[ADMIN] %name% just joined. Hide your bananas!",

    -- Level 4:
    --
    [4] = "[SENIOR-ADMIN] %name% joined the server.",

    -- Where should messages appear, chat or rcon?
    --
    environment = "chat",

    -- Message alignment (has not affect for clients running Chimera)
    -- Left = |l, Right = |r, Center = |c, Tab: |t
    --
    alignment = "|l",

    --

    -- Advanced users only:
    --
    -- A message relay function temporarily removes the server prefix
    -- and will restore it to this when the relay is finished:
    -- Technical note: This only applies to the chat environment.
    server_prefix = "**SAPP**",
    --
}
-- config ends --
ghost commented 3 years ago

Awesome bro! 😃

github-actions[bot] commented 2 years ago

Stale issue message