search

Chalyan / SICP

0 stars 0 forks source link

Makefile and file including dissonance #24

Open Chalyan opened 2 years ago

Chalyan commented 2 years ago

While we tried to add our tests to Makefile, we faced an issue in the scale of including files. We investigated the problem and found out, that it is connected with the fact of changing directions in Makefile while using the cd command.

We faced this issue in PR #23

amuradyan commented 2 years ago

@Chalyan Good job. I have a few suggestions.

The title is not descriptive. A new method is equally a change as the imports and includes. We are opening this issue, to note a problem with cd-s in the makefile and include-s in Scheme.

I suggest we simplify the an issue in the scale of including files.

For this, we took into consideration using so-called super-directions, and by this, the /home/user/playground/SICP directory will become the root.

The line above describes implementation details. I suggest we do not include this in the issue /not before the implementation, at least/.

I also think it lacks a /concise/ description of the issue.

Chalyan commented 2 years ago

Thank you for your notes. Is it descriptive now?

amuradyan commented 2 years ago

Great title.

I don't like the usage of scale and I think the We investigated the problem and found out, that is a long way of starting a problem definition.

It turns out that changing directories to run the tests in the makefile affects the relative paths of include-s in Scheme code. One way of working around this is to get rid of cd-s in the makefile and run the tests directly, and normalize the include-s relative to a root folder.

What do you think about this?

Chalyan commented 2 years ago

I do like the way you described the problem. Should I change the existing one with your suggestion?

amuradyan commented 2 years ago

@Chalyan you can replace it or you can rephrase it: your issues, your calls )))