search

ChameleonFramework / Chameleon

Cross-platform Minecraft plugin framework
MIT License
36 stars 7 forks source link

Decouple managers from platform's Chameleon #215

Open LooFifteen opened 1 year ago

LooFifteen commented 1 year ago

Confirmation

Problem

Currently, when creating support for a Bukkit-based platform, BukkitChameleon must be extended to grant access to Bukkit's manager classes. If these managers begin to use the abstracted classes rather than the internals where possible, it'll be less hacky when adding a platform like this to Chameleon.

Suggested solution

Prefer abstract classes over internal implementation in managers.

Additional information

No response

LooFifteen commented 1 year ago

This is solved, right?

joshuasing commented 1 year ago

This is solved, right?

The Bukkit managers have been decoupled. I meant to ask whether you also wanted other platforms decoupled (which I don't really see much of a reason to do this, right?).