Champs-Libres / wopi-lib

A standard and framework agnostic PHP library to facilitate the implementation of the WOPI protocol.
https://github.com/champs-libres
MIT License
12 stars 1 forks source link

Should the use of CacheItemPoolInterface be an implementation detail ? #22

Closed julienfastre closed 2 years ago

julienfastre commented 2 years ago

The DocumentLockManager use CacheItemPoolInterface to store the lock.

This is comprehensive because lock must store some bytes, and be able to write and save it. It provides a quick way for locking file without requiring some adaptations in the database.

But what about those who do not use caching ? Should we not let dev use their own implementation ?

Proposal:

github-actions[bot] commented 2 years ago

Since this issue has not had any activity within the last 5 days, I have marked it as stale. I will close it if no further activity occurs within the next 5 days.