Treat CAVE_AIR just like normal AIR blocks

[fuhry]

Recently, Minecraft began using CAVE_AIR for air blocks inside of caves, however AncientGates presently does not recognize this as air and refuses to construct portals inside of caves.

This PR resolves this issue. It has been successfully tested on a server running Minecraft 1.20 with no issues.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[ChanceSD]

Thank you, unfortunately that probably stops the plugin from working in older versions where Material.CAVE_AIR doesn't exist. If you could replace that with something from XMaterial, I'm not sure if XMaterial.AIR already includes cave air or not, if so it would be the easiest way to support all versions.

If you can't change that I will try to test it and adjust your PR,, thank you either way though since getting a new PR is very rare

[fuhry]

@ChanceSD Thanks for this, sorry that I didn't see your comment until now!

I'll look into adapting this to XMaterial and update the PR.

[fuhry]

Update - I made the changes but still need to test them, I'll get that done this week.

[ChanceSD]

@fuhry Any update on this? No problem if not

[fuhry]

@ChanceSD I haven't had a chance to actually test this yet. Do you still need that done?

[ChanceSD]

I didn't try it either tbh

[fuhry]

I've finally gotten around to testing this now that 1.20 is released. I'm getting the "the from location is not air" message with both XBlock.isAir() and XMaterial.AIR.matchXMaterial(). The isAir() function looks particularly simple, so I don't know what's going on. Here's my squashed code versus the latest state of master..

Edit: I was missing a ! operator. Update incoming.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[fuhry]

@ChanceSD Just wanted to let you know this should now be ready to merge!

I've noticed a couple of other issues, which I'm fairly certain are separate. If you think any could be regressions introduced by this PR, can you let me know? Otherwise I'll file separate issues and pull requests for them.

1. Decorative non-obstructing block types, like grass, flowers, etc. can't be placed around a gate
2. Water, sugar cane and potentially other block types aren't replaced with air when a gate closes. Particularly problematic for water as this causes flooding
3. A room with several gates that use water as a material can experience flooding in all gates when one gate is closed

Have a feeling 2 and 3 are related, and maybe 1 is intended to prevent 2 and 3 from happening, will peek into the Bukkit/Spigot APIs to see if flow recalc can be inhibited directly.

[CatTeaA]

bump

[ChanceSD]

Sorry, it's been so long, I will fix the conflicts and merge it soon. And yes, I believe there are some issues with water currently, not sure if possible to fix.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[ChanceSD]

Should be good, merging now, thank you for your contribution!