Re-enable pvpmanager.nopvp, This was used for temp staff ranks.

TomLewis commented 1 week ago

I have no idea what repo to post in there are two? https://github.com/ChanceSD/PvPManager-Issues/issues/191

Is your feature request related to a problem? Please describe. The purpose I used pvpmanager.nopvp was to have ranks not be in PvP, for example I have a "gardener" rank that is temp given to players to clean up the world, I also have a second temp rank called "Media" that takes screenshots, These two ranks need to have PvP disabled for both them attacking and others attacking them when they are busy in staff mode. When the ranks run out (via lp) then this permission auto removes.

Personally I would never need to use the world manager setting for any purpose, but I really need that pvpmanager.nopvp.

Just spent like 30 mins trying to figure out why the hell it wasn't working, then did a verbose and noticed it didn't exist, then had to backtrack changelogs...

please can we get it back!

Other permissions I also had in these staff ranks were;

- pvpmanager.nopvp:
    world: PirateCraft_1
    value: true
- pvpmanager.nopvetag:
    world: PirateCraft_1
    value: true
- pvpmanager.nocombat:
    world: PirateCraft_1
    value: true

ChanceSD commented 1 week ago

Those perms caused too many problems because some owners gave themselves the * permission, and complained they couldn't toggle pvp, etc. Even if I specify in plugin.yml they shouldn't be given by default LP gave them anyways, this didn't use to be a problem when GroupManager/PermissionsEx were the most used permissions plugins, LuckPerms works different but that's another conversation. A couple ideas to solve your issue:

can't you run /pvp off for those players when giving them the rank? And then pvp on at the end?
in the premium version there's also /pvpgrant, so you could also give them temporary protection for the duration of the rank

TomLewis commented 1 week ago

What about a toggle in the config to enable these permissions, default to off? Then we can just use them as intended!

I have had to compromise with /pvp off for now, BUT the issue is when the rank runs out, it dousnt auto remove this, if this was the permission it would auto be disabled, so now I have staff stuck with PvP off, plus theres ways this could not trigger if I did have some sort of janky setup to disable it somehow at the end.
I do have the premium version but its 1 extra step they need to remember to do, before we just had it all automated, they click a button get the rank for X time, nothing else required.

ChanceSD commented 1 week ago

When I mentioned running /pvp off, I had automation in mind. I don't know what system you are using to give that rank but can't it execute /pvp off <player> in console and then /pvp on at the end? If it can run commands you should be able to automate it.

With /pvpgrant it might be even easier, since you can just run it once at the start and it enables pvp after the X time.

TomLewis commented 6 days ago

Temp ranks are done the same as any other server, luckperms temp parent. It auto expires itself.

Just need the perm to work, as it did before. No extra added complexity.

ChanceSD / PvPManager

Re-enable pvpmanager.nopvp, This was used for temp staff ranks. #508