search

ChanceSD / PvPManager

A Spigot/Paper plugin to toggle PvP, stop combat log, protect new players and much more
https://www.spigotmc.org/resources/pvpmanager.845/
Other
132 stars 47 forks source link

PlayerHitPlayer event collision with RevivalMe #536

Closed insidethehearts closed 1 hour ago

insidethehearts commented 4 hours ago

Describe the bug

I have a fork on dying condition that prevents player 1 from hitting player 2 when player 1 is in dying condition. With your plugin (Premium version) player 1 can be player 2 when in a state before death. (I think, your plugin use hitEvent.setCancelled(false).)

To reproduce the bug

  1. Insatll PvPManager Premium & RevivalMe
  2. Get a state before death
  3. Try to hit a opponent

Server: Core - Paper 1.20.4 PvPManager Premium - latest

ChanceSD commented 3 hours ago

I can barely understand what you're trying to say but set vulnerable to false in config, will probably solve it.

insidethehearts commented 2 hours ago

What kind of vulnerability are we talking about?

ChanceSD commented 2 hours ago

It's a config option, named Vulnerable

insidethehearts commented 1 hour ago

It's really fixed my problem. I am set this function to 'false' by default. In any case, thanks for the prompt response!