Changing the Target name of a Segment does not update in the MB or Plotter legend

[jbudynk]

To reproduce: build a SED with the TestBuilder (add a NED SED and a user SED). Since the target names are the same, the MB and Plotter legend update the names in their respective components as expected: one is "3c066a" and the other is "3c066a 1."

If I change the target name of one of the segments in the Builder to "3c066a mine" or something different from the other segment, neither the legend nor the MB segment name updates. I would expect the segment name to change to "3c066a mine".

It looks like a SegmentEvent isn't being caught, but I'll need to look more into this.

version: ChandraCXC/iris@b5e635b52f

[jbudynk]

From an offline conversation with @eholum :

We could fix this by tying everything in the star table to the segment name in the SED Builder. The problem with this is that in the ExtSed you can have multiple segments of the same name, so we would have to change the condition in the Metadata Browser and legend that segments must have unique names. It's the Visualizer that adds the "_1" to each segment. We'd also need to make sure the layer names are unique so we get the proper legends and color coding.

[eholum]

Could also add a changed notification here:

https://github.com/ChandraCXC/iris/blob/master/sed-builder/src/main/java/cfa/vo/sed/gui/SedBuilderMainView.java#L1218

But change notifications are expensive for large segments.

[jbudynk]

I noticed that the SED name doesn't automatically update either, though it does update on the plot with a Reset.