No validation checks done for RoleReq.txt

[Chang-CH]

Steps to reproduce

1. edit RoleReq.txt with illegal values, such as

0 -1 -1

or

abc 0 0

Expected

• Save file should be reset with an error message

Actual

• in the case of invalid ranges, software runs as per usual, but with invalid values:

• in the case of invalid values such as abc, software crashes and is unable to launch with no error UI messages.

App should minimally continue running. While this issue is unlikely to happen the results can be disastrous (app cannot start). Error messages would help as well.

[nus-pe-bot]

Team's Response

It should be a low severity, given that a manager does not frequently use modify the data files, and that there is no such thing as a negative role requirement, an average user would realise the typo when editing the file anyways.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

• [x] I disagree

Reason for disagreement: App is unusable in response to a user typo, e.g. a 0 0 instead of 0 0 0 in the save file.

• Severity of outcome: Uncaught exception, app crashes on startup and cannot be launched, nothing happens when double clicking the jar. No error messages are present, so user cannot troubleshoot themselves. Severity Medium indicates that users can continue to use the product. This is not the case here, users cannot even open the app.

• Frequency of occurrence: Issue happens due to a typo, which is common. Editing RoleReq.txt is endorsed by the team, so editing is to be expected.

While this might not happen to all users, outcome is disastrous (cannot use app, no ability to troubleshoot). This is similar to an example in the PE readiness quiz:

This does not match the description of a Low severity issue.

---