search

Chang-CH / pe

0 stars 0 forks source link

`add` allows adding of likely similar people #6

Open Chang-CH opened 3 years ago

Chang-CH commented 3 years ago

Steps to reproduce

  1. Enter add n/John Doe p/98765432 e/johnd@example.com $/100 r/bartender s/fulltime r/kitchen t/friends t/owesMoney
  2. Enter add n/John Doe p/98765432 e/johnd@example.com $/100 r/bartender s/fulltime r/kitchen t/friends t/owesMoney

Expected

-It is likely that "John Doe" is the same as "John Doe". Similar to how case sensitivity is implemented the software should detect that they are likely to be duplicates. A user could have pressed space twice by accident.

Actual

image.png

nus-pe-bot commented 3 years ago

Team's Response

It is not within the product requirements to catch such errorneous input by the user. We allow similar names to mark to people with the same name, which allows for a restaurant to use their own way to signify that the two staff with different names are different. In this case, two spaces may be used by the restaurant to do so. Additionaly, what if it was the intent to have a name with two spaces? As the name is just a means for the restaurant to identify the staff in a human-friendly manner, there appears to be no benefit from removing the ability to have two similar names.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This issue is mentioned in the PE guidelines on Bugs related to duplicate detection:

image.png

There should minimally be some form of warning for the user.