Changaco / python-libarchive-c

Python interface to libarchive
Other
70 stars 37 forks source link

read PKG-INFO, README as utf-8 #120

Closed bollwyvl closed 2 years ago

bollwyvl commented 2 years ago

Thanks for python-libarchive-c, and congratulations on 4.0!

This tries to read PKG-INFO as utf-8 to avoid situations like this, encountered downstream on conda-forge (log):

Processing d:\bld\python-libarchive-c_1642883867449\work\dist
  Added file:///D:/bld/python-libarchive-c_1642883867449/work/dist to build tracker 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pip-req-tracker-j2qxfoak'
  Running setup.py (path:%SRC_DIR%\dist\setup.py) egg_info for package from file:///D:/bld/python-libarchive-c_1642883867449/work/dist
  Created temporary directory: C:\Users\VssAdministrator\AppData\Local\Temp\pip-pip-egg-info-kwop4uuv
  Running command python setup.py egg_info
  Preparing metadata (setup.py): started
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "D:\bld\python-libarchive-c_1642883867449\work\dist\setup.py", line 12, in <module>
      version=get_version(),
    File "D:\bld\python-libarchive-c_1642883867449\work\dist\version.py", line 39, in get_version
      version = version_re.search(f.read()).group(1)
    File "D:\bld\python-libarchive-c_1642883867449\_h_env\lib\encodings\cp1252.py", line 23, in decode
      return codecs.charmap_decode(input,self.errors,decoding_table)[0]
  UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 4499: character maps to <undefined>
WARNING: Discarding file:///D:/bld/python-libarchive-c_1642883867449/work/dist. Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
  Preparing metadata (setup.py): finished with status 'error'
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

I guess a follow-on might be to do some testing on non-linux platforms on CI.

Thanks again!

Changaco commented 2 years ago

Thanks.