search

ChangemakerStudios / serilog-sinks-mongodb

A sink for Serilog that writes events to MongoDB
Apache License 2.0
92 stars 53 forks source link

Sink should override EmitBatchAsync() #14

Closed nblumhardt closed 8 years ago

nblumhardt commented 8 years ago

Instead of waiting on tasks as in https://github.com/serilog/serilog-sinks-mongodb/blob/dev/src/Serilog.Sinks.MongoDB/Sinks/MongoDB/MongoDBSink.cs#L157, the sink should override PeriodicBatchingSink.EmitBatchAsync() and use await.

Jaben commented 8 years ago

Done in dev branch.