search

ChangemakerStudios / serilog-sinks-mongodb

A sink for Serilog that writes events to MongoDB
Apache License 2.0
92 stars 53 forks source link

Updating to use .NET Core #9

Closed brantw closed 8 years ago

brantw commented 8 years ago

I took a stab at updating the MongoDB sink to .NET Core / Serilog 2.0. The sink is still constrained to the full CLR due to the MongoDB.Driver dependency (which the MongoDB team is working on updating).

Feedback welcome.

nblumhardt commented 8 years ago

Thanks Brant!

In v2, PeriodicBatchingSink has moved to Serilog.Sinks.PeriodicBatching on NuGet, so hopefully the churn should be a bit less with that pulled in.

brantw commented 8 years ago

Ah, I wondered where that went. I'll update to use batching.

brantw commented 8 years ago

Updated to use periodic batching.

nblumhardt commented 8 years ago

Thanks for the update Brant! I think the diff is made much larger by the whiltespace/formatting-type changes, it'd be great to minimise these so that folks following along can easily check out what's new in this version.

Looking good though!

brantw commented 8 years ago

I probably made those whitespace, variable name changes when I was testing the conversion before pulling in the PeriodicBatchingSink package. Should be updated now.

brantw commented 8 years ago

Any update on this after my last commit?

merbla commented 8 years ago

@brantw were you waiting for a nuget package?

There is only the master branch here. Generally we will hang off pushing this to master until .Net Core goes RTM.

In the meantime would you like AppVeyor to be configured to spit out beta packages?

amcdnl commented 8 years ago

@merbla -

Isn't Serilog main is .net core compatible? Why would you not make the sinks if so? Thats the whole reason we switched to Serilog was that reason.

Yes, a beta package would be great, but to be honest it feels like it won't be til next year until RTM is available. RC1 is supported by Microsoft and treated as a viable production deployment option.

brantw commented 8 years ago

Yes, a beta package would be great.

nblumhardt commented 8 years ago

Hey all - I should have some time to look into this today, I'll create a dev branch here and get this PR merged to it (the ticket won't close until it hits master, but that's still easier than retargeting :-) )

nblumhardt commented 8 years ago 
Publishing Serilog.Sinks.MongoDB.3.0.0-beta-24.nupkg to https://www.nuget.org/api/v2/package...OK
Total packages published: 1
Build success

Now merging this PR to dev..

nblumhardt commented 8 years ago

Merged to dev; new package should be out as -25

https://ci.appveyor.com/project/serilog/serilog-sinks-mongodb

PR won't show as merged until this hits master; changed the default branch for future PRs.

nblumhardt commented 8 years ago

Looks like there was a problem with CI - I was expecting this to be out :-( ... Looking into it now.