search

ChannelFinder / recsync

EPICS Record Synchronizor
Other
15 stars 25 forks source link

add iocIP prop by default, pvaPort and caPort as optional properties that default on (opt-out) #91

Closed tynanford closed 4 months ago

tynanford commented 5 months ago

Addresses this issue ticket https://github.com/ChannelFinder/recsync/issues/90

Adds a new default property iocIP and adds a new preference settings iocConnectionInfo which defaults to on. If this property is enabled, the other two port properties will also be sent to channel finder - pvaPort and caPort. A user who does not want these properties can toggle iocConnectionInfo to off.

In the case reccaster or EPICS base is an older version that does not support RSRV_SERVER_PORT or PVAS_SERVER_PORT (or QSRV is not enabled), recceiver will just skip adding this property to the channel.

2024-06-14T13:49:17-0400 [recceiver.cfstore#debug] EPICS environment var RSRV_SERVER_PORT listed in environment_vars setting list not found in this IOC: test-
ioc
2024-06-14T13:49:17-0400 [recceiver.cfstore#debug] EPICS environment var PVAS_SERVER_PORT listed in environment_vars setting list not found in this IOC: test-
ioc
sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

tynanford commented 4 months ago

@shroffk is this okay to merge?

shroffk commented 4 months ago

This PR implements the improvements discussed during the codeathon