ChaosMarc / PlugY

PlugY, The Survival Kit - Plug-in for Diablo II Lord of Destruction
GNU General Public License v3.0
179 stars 41 forks source link

Support 1.14 #3

Closed KornelJahn closed 3 years ago

KornelJahn commented 8 years ago

Thanks for updating PlugY to support 1.13d. Any plans on supporting 1.14?

Update: I have noticed that work is in progress.

LAutour commented 8 years ago

Any plans on supporting 1.14?

Yes

SilverSix311 commented 7 years ago

Any news on this?

LAutour commented 7 years ago

work, work, work :(

Harest commented 7 years ago

Just started to play Diablo 2 some days ago and i now know the mod MrLlamaSC is using to have this infinite stash (only option i'm interesting in) is this one, PlugY. Crazy there's not a damn thing on the authors of this mod on the official "site" (or should i say page). I saw a "Yohann" in a wiki and that's all.

Just wanted to know what was the compatibility issues of the mod with the latest version of D2 LOD ? Even if i'll probably not be able to help :/. Edit : By looking into the last commits it seems mainly new ram address required ?

ChaosMarc commented 7 years ago

@LAutour Yohann released another update (11.02) which collides with your changes. Could you please redo/copy your preparations for 1.14 into a separate branch as the changes are major and shouldn't be commited to the master branch. For the time being I created a branch 11.02 which is exactly Yohann's code without any changes by the community.

drauch commented 6 years ago

Is there any work ongoing or has the idea of a port to 1.14 been abandoned?

ChaosMarc commented 6 years ago

I cleaned up the branches a bit. Master now is the latest official version by Yohann (11.02) with the translation fixes previously done in this repo. LAutour's 1.14 Code can be found in a separate branch called "1.14"

no actual progress toward a 1.14 compatible version has been done by me!

drauch commented 6 years ago

Thanks for the update @ChaosMarc .

@LAutour are you working on an 1.14 version still or have you abandoned the project?

manu666fr commented 6 years ago

Hi guys, Thank's for your great work. @LAutour are you working on an 1.14 version still or have you abandoned the project? byebye ;-)

hossomi commented 5 years ago

Is there any... thing I can read to help understand and contribute to this?

stonecrusher commented 5 years ago

@hossomi Maybe this thread / forum is helpful?

ChaosMarc commented 5 years ago

@stonecrusher is correct. In general the Phrozen Keep, especially the PlugY and Code Editing section are good starting points.

Gragog commented 4 years ago

Any news on this? I couldn't run any 1.13 version on my PC (crash on start with ACCESS_VIOLATION (c00000005) EXCEPTION). I would be happy to use this mod.

ChaosMarc commented 4 years ago

@Gragog If you're having problems running plugy with 1.13 please create a new ticket but I think a full removal of diablo II and a clean install will fix your problems.

For your actual question: I just found out that there is a new version of plugy which supports 1.14d. I'm trying to contact the creator so we can merge both repositories: https://github.com/haxifix/PlugY

ChaosMarc commented 3 years ago

I finally found the time and merged the two code bases. I have created a new release with all credits to https://github.com/haxifix: https://github.com/ChaosMarc/PlugY/releases/tag/12.00

drauch commented 3 years ago

So nice! I see that you're also closing lots of bugs so probably another minor step upcoming? : )

Do you know that Windows Defender detects PlugY 12 as a trojan horse?

Best regards, D.R.

ChaosMarc commented 3 years ago

@markm11 told me he was working on a fix for https://github.com/haxifix/PlugY/issues/12. I'm waiting for that and will release v12.01 afterward

regarding the "trojan horse". I didn't know that. thanks for the info. I will look into that

drauch commented 3 years ago

Windows Smart Screen and heuristic detection algorithms of the Windows Defender may be to blame. Oftentimes this goes away after enough users have installed the new version (or after you have code-signed your software, but that's probably not an option for you because of the certificate costs).