Chaoses-Ib / ComfyScript

A Python frontend and library for ComfyUI
https://discord.gg/arqJbtEg7w
MIT License
431 stars 24 forks source link

Trouble Running Example Script with Custom Model in Conda Environment on Windows 10 #23

Closed Gerkinfeltser closed 9 months ago

Gerkinfeltser commented 9 months ago

Hello,

Firstly, I want to express my gratitude for the effort and dedication you've put into developing this project. It's evident that it holds substantial promise. However, I've encountered some challenges while attempting to execute scripts.

I followed the installation process outlined for ComfyScript using the "Package and nodes with ComfyUI" method, opting for a standalone (non-portable) version of comfyui. For your information, my setup involves running comfy within a conda environment on a Windows 10 system.

I attempted to run the example script provided in the README.md file of the repository, making a minor modification to use a different model that I possess. You can find the script I used here: test.py.txt.

Encountering errors, I've captured and shared the log for your review: ComfyScript.log.

Could you offer any guidance or suggestions on how to resolve these issues and successfully run the script? Any advice would be greatly appreciated.

Thank you for your support.

Chaoses-Ib commented 9 months ago

Have you tried to load with another ComfyUI server? i.e. start ComfyUI manually, and then

from comfy_script.runtime import *
load('http://127.0.0.1:8188/')
from comfy_script.runtime.nodes import *
Chaoses-Ib commented 9 months ago

This bug is now fixed. Thanks for your report. Please run git pull to update and try again.

Gerkinfeltser commented 9 months ago

Awesome! Thanks for the quick fix! I'm still getting errors upon running the script but the image gets generated!

Here's the log (using exact same script as above). Again, while the errors are annoying, it works. comfyui.log

Thanks again!

Chaoses-Ib commented 9 months ago

The remaining errors are all about some special custom nodes. You can use other nodes normally. I'll fix these errors one by one, but that may take several days to finish. If there are nodes you want to use at now in them, you can comment here and I'll fix them first.

FYI, here is a list of broken nodes in your log:

0246.ScriptRule
0246.ScriptPile
List of any [Crystools]
XY Input: Lora Block Weight //Inspire
LoraLoaderBlockWeight //Inspire
Reorder
ModelFinder
CombineJobs
GetJobStep
JoinImageBatch
JoinImages
FaceStyler
MaterialsStyler
ComfyUIStyler
FaceStylerAdvanced
MaterialsStylerAdvanced
ComfyUIStylerAdvanced
ttN xyPlot
Qr Code (mtb)
Text To Image (mtb)
HighRes-Fix Script
Chaoses-Ib commented 9 months ago

Wow, comfyui-styles-all adds ~500k values to the value list, that's crazy... So much values make loading too slow. I need to do some optimizations, or ignore too large lists.

Chaoses-Ib commented 9 months ago

There are actually fewer bugs than I thought. According to my test, most nodes are fixed now. The only remaining problem is about ttN imageOutput.number_padding, but it's just an enum, you can use string/int literals to workaround it.

Nodes: 1148
ComfyScript: ttN imageOutput.number_padding: Invalid enum value: 2
ComfyScript: ttN imageOutput.number_padding: Invalid enum value: 3
ComfyScript: ttN imageOutput.number_padding: Invalid enum value: 4
ComfyScript: ttN imageOutput.number_padding: Invalid enum value: 5
ComfyScript: ttN imageOutput.number_padding: Invalid enum value: 6
ComfyScript: ttN imageOutput.number_padding: Invalid enum value: 7
ComfyScript: ttN imageOutput.number_padding: Invalid enum value: 8
ComfyScript: ttN imageOutput.number_padding: Invalid enum value: 9
Gerkinfeltser commented 9 months ago

Awesome, thanks again for looking into this! I super appreciate it & am sorry for the extra work!