search

Chaosthebot / Chaos

A social coding experiment that updates its own code democratically.
http://chaosthebot.com
MIT License
2.44k stars 210 forks source link

FIX ERROR PAGES WITH THIS ONE SIMPLE TRICK #455

Closed mdcfe closed 7 years ago

mdcfe commented 7 years ago

This fixes the display of the error code in #439 - the previous page worked on Python 3.4 (installed by default by Vagrant until #454), but the way error codes work for SimpleHTTPRequestListener changed in Python 3.5.

o3LL commented 7 years ago

Damn, we are not on youtube 😆

mdcfe commented 7 years ago

Doesn't seem like ChaosBot is counting the right number of votes - shouldn't it be at least 9 positive not 5 (mine + 8 👍s)?

PlasmaPower commented 7 years ago

@md678685 Some votes are probably from accounts < 1 month old.

rudehn commented 7 years ago

@PlasmaPower what if we change that rule? Any account < 1 month old that submits a PR and is accepted would have their vote count

PlasmaPower commented 7 years ago

@rudehn I'll submit a PR for that.

mdcfe commented 7 years ago

It still hasn't changed - is it broken?

andrewda commented 7 years ago

Yea - one of the earlier PR's broke it. It keeps crashing due to the labels API returning a 422 status and the bot not accounting for that properly http://chaosthebot.com:8081/chaos-stderr.log

rudehn commented 7 years ago

Looks like it's time for another hotfix. Here's an idea, we automatically email @amoffat when chaosbot had a fatal error 😆

andrewda commented 7 years ago

Or text him ;)

amoffat commented 7 years ago

lol. yeah there is no real good way for me to know. i have the logs constantly scrolling and check it every few hours

chaosbot commented 7 years ago

:ok_woman: PR passed with a vote of 16 for and 0 against, a weighted total of 15.5 and a threshold of 6.5, and a current meritocracy review.

See merge-commit 9f9c1b0ea9f2318257484dea38b6ba4f1b741cc7 for more details.