search

Chaosthebot / Chaos

A social coding experiment that updates its own code democratically.
http://chaosthebot.com
MIT License
2.44k stars 210 forks source link

Fix meritocracy mentions and extended voting window #500

Closed PlasmaPower closed 7 years ago

PlasmaPower commented 7 years ago

Now it must be running in production, and it will not mention the author of the PR (as they cannot review their own PR).

Edit: in addition, the PR must not be in the base voting window.

PlasmaPower commented 7 years ago

Oops just realized the code for the extended voting window is still broken (as seen in #503). Fixing.

chaosbot commented 7 years ago

:warning: This PR has reached its extended voting window, but it does not have a positive meritocracy review.

Please review: @xyproto @phil-r @smittyvb @muchzer @rudehn @md678685 @chaosbot @viktorsec @ad-m @hongaar @eukaryote31 @andrewda @plasmapower @rhengles @amoffat

Swizz commented 7 years ago

Chaosbot still stealing a Meritocratic chair

mark-i-m commented 7 years ago

@chaosbot will be in the meritocracy for a while because it was the merger on all PRs before we switched to squashing...

mark-i-m commented 7 years ago

@PlasmaPower while we're at it, you could filter out @chaosbot from the meritocracy review post.

PlasmaPower commented 7 years ago

@mark-i-m Will do. BTW I figured out why the extended voting window was/is malfunctioning, will explain after fix.

PlasmaPower commented 7 years ago

This now also saves an extra API call per PR check (it got the last updated time twice).

PlasmaPower commented 7 years ago

Rip chaosbot again? http://chaosthebot.com:8081/chaos-stderr.log

That 404 seems to be common, not quite sure why it happens though.

chaosbot commented 7 years ago

:warning: This PR has reached its extended voting window, but it does not have a positive meritocracy review.

Please review: @xyproto @phil-r @smittyvb @muchzer @rudehn @md678685 @chaosbot @viktorsec @ad-m @hongaar @eukaryote31 @andrewda @plasmapower @rhengles @amoffat

chaosbot commented 7 years ago

:warning: This PR has reached its extended voting window, but it does not have a positive meritocracy review.

Please review: @xyproto @phil-r @smittyvb @muchzer @rudehn @md678685 @chaosbot @viktorsec @ad-m @hongaar @eukaryote31 @andrewda @plasmapower @rhengles @amoffat

PlasmaPower commented 7 years ago

(this PR actually needs a meritocracy review - @andrewda?)

chaosbot commented 7 years ago

:white_check_mark: PR passed with a vote of 11 for and 0 against, a weighted total of 11.0 and a threshold of 6.5, and a current meritocracy review.

See merge-commit 331c5b4774c2bd88987e132391662d9525bd7e58 for more details.