search

Chaosthebot / Chaos

A social coding experiment that updates its own code democratically.
http://chaosthebot.com
MIT License
2.44k stars 210 forks source link

HOTFIX - vote spam #523

Closed rudehn closed 7 years ago

rudehn commented 7 years ago

This is a hotfix to help stop the vote spam we are seeing. Here's how it works.

  1. A command is identified and ran
  2. The command is then put into the InactiveCommands table to signify it ran

The previous problem was that when identifying new commands, we didn't check if it was already in the inactive commands list.

What does this PR solve? Well it won't re-add commands to the db to be run. HOWEVER it won't solve the problem if there is an issue removing commands from the ActiveCommand table.

Either way, this check needs to be in.

Also, my apologies for the goof. I thought I had tested pretty well but something must have slipped through the cracks.

paris-ci commented 7 years ago

:+1:

chaosbot commented 7 years ago

:white_check_mark: PR passed with a vote of 11 for and 0 against, a weighted total of 10.5 and a threshold of 6.2, and a current meritocracy review.

See merge-commit f2a2130145f7935b9c6a78ef01dd5b7621abbc49 for more details.