ChaoticTrials / AIOTBotania

This mod adds AIOTs to Botania.
https://modrinth.com/mod/aiot-botania
MIT License
11 stars 12 forks source link

Issues with mana bursts of Terrasteel and Alfsteel AIOT #73

Closed VortexOfRainbows closed 1 year ago

VortexOfRainbows commented 1 year ago

Minecraft version

1.19.2

AIOT Botania version

1.19.2-3.0.0

Botania version

1.19.2-436

Forge version

43.2.3

The latest.log file

N/A (not a crash)

Issue description

Mana burst from Terrasteel AIOT does not create sound. Mana burst from Terrasteel AIOT does not deal damage. Mana burst from Alfsteel AIOT only spawns when hitting an entity, not when swinging (but it does deal damage). Also creates no sound. Sound is created in multiplayer, but is muted for the player who swings the weapon. (I believe the fix would be changing the first parameter in the sound creating function)

Steps to reproduce

  1. Obtain Terrasteel AIOT
  2. Swing Terrasteel AIOT. Observe the lack of swing sound.
  3. Swing Terrasteel AIOT, aiming for a mob. Observe the lack of damage on the mob.
  4. Swing Alfsteel AIOT, aiming for a mob. Observe the lack of mana burst (and lack of sound)
  5. Swing Alfsteel AIOT, directly hitting a mob, and observe the presence of a mana burst (this one deals damage).

Other information

The Terrasteel blade from Botania and the Terrasteel AIOT seem to have discrepancies in the number of methods they each have, particularly with the public void updateBurst(ManaBurst burst, ItemStack stack) function in the Terrasteel Blade.