search

ChaoticTrials / MoreVanillaArmor

Armor made of vanilla material
https://modrinth.com/mod/morevanillaarmor
Apache License 2.0
2 stars 4 forks source link

Lightning Magnet set bonus works with every armor set #21

Closed gregoryeple closed 1 year ago

gregoryeple commented 1 year ago

Version MoreVanillaArmor-1.19.1-4.1.1

All armor sets act as a lightning magnet instead of just the copper one.

The problem seems to come from the file Events.java

// Current code
.filter(livingEntity -> Armor.getArmorSetType(livingEntity) != null)
// Suggested change
.filter(livingEntity -> Armor.getArmorSetType(livingEntity) == ArmorTiers.COPPER)
MelanX commented 1 year ago

Thank you very much!

gregoryeple commented 1 year ago

I Just checked the commits, doesn't it make it apply to every armor set except the copper one?

// For reference, the code in the commits
.filter(livingEntity -> Armor.getArmorSetType(livingEntity) != ArmorTiers.COPPER)
MelanX commented 1 year ago

Oof you’re right… will fix it tomorrow.