search

ChaoticTrials / SimpleBackups

A simple mod to create scheduled backups
https://modrinth.com/mod/simple-backups
Apache License 2.0
10 stars 6 forks source link

Server hanging when simpleBackups tries to delete old backups. #4

Closed StormCircuit closed 2 years ago

StormCircuit commented 2 years ago

Minecraft version

1.18.2

Simple Backups version

1.1.5

Forge version

40.0.41

The latest.log file

https://pastebin.com/RWS9HRK5

Issue description

Simplebackups starts a backup and then consumes the tick cycle until the server crashes. It is worth noting I use symbolic junction links to backup files. In this scenario the simplebackups file is the original file and the junction link is on another drive.

Steps to reproduce

Get a backup scheduled Join a server to start it as configured above Witness a crash due to server watchdog.

Other information

Modpack is latest version here: https://www.curseforge.com/minecraft/modpacks/attlerock-1-18 crash log: https://pastebin.com/5S981Pmc

MelanX commented 2 years ago

What is you exact config for that? When trying to reproduce, I get an exception because this file already exists. Maybe my English wasn't good enough to understand but I think I did it correctly.

StormCircuit commented 2 years ago

I used a junction symbolic link. So To be specific I used: "mklink /J 'target on the other drive' 'simplebackups folder' "

StormCircuit commented 2 years ago

And not a problem at all, let me know if I can provide anymore info! Love the mod!

MelanX commented 2 years ago

To be honest, I never did something like that and trying to reproduce that results in the same error as before: An exception that the file already exists... Why are you using this link and not setting this path directly?

Thank you!

MelanX commented 2 years ago

I know, you should never just download a zip file or jar. This is a jar in a zip file :D Could you please test this? I don't want to just publish it without being sure that it fixes your problem because it could introduce more bugs. SimpleBackups-1.18.2-Test-1.1.0.zip

StormCircuit commented 2 years ago

I will try it! I honestly somehow didn't know about the other directory. The last backup mod didn't support it so I assumed yours wouldnt as well. My bad. I will try the config change too.

StormCircuit commented 2 years ago

Appears to work, dropped it in as a replacement and it completed a backup without issue of 18 GB. Thank you!

MelanX commented 2 years ago

Awesome, will upload the fix later, then you can get an official version :)