ChaoticTrials / SkyblockBuilder

Let you create a custom skyblock island via config
https://modrinth.com/mod/skyblock-builder
Apache License 2.0
8 stars 6 forks source link

Modded dimensions aren't loaded properly on creating the world #104

Closed MelanX closed 2 years ago

MelanX commented 2 years ago

Minecraft version

1.19.2

LibX version

1.19.2-4.2.6

Skyblock Builder version

1.19.1-4.2.0

Forge version

43.1.33

The latest.log file

unnecessary

Issue description

Dimensions by other mods are likely not loaded with Skyblock world preset. Because of this, these dimensions can't be visited or used as starting dimension. However, after re-loading the world, the dimensions are back in.

Steps to reproduce

  1. Add a mod which adds new dimensions (e.g. Cosmopolis runtimeOnly curse.mod(556904, 4016840)) to dependencies.
  2. Run the runClient task.
  3. Create a new world with world preset Skyblock.
  4. Try to type in /execute in and see that the dimensions are not listed. Manually typing doesn't help, too.

Other information

While trying to find the cause, I found out that the datapack dimensions are added in CreateWorldScreen#tryApplyNewDataPacks. It seems like the Skyblock world preset isn't loaded at the time this is being called.

MelanX commented 2 years ago

https://github.com/MelanX/SkyblockBuilder/commit/640455a16fccbd560f40274df6c4cf216580a859