search

Chapabu / codeception-module-drupal

MIT License
9 stars 7 forks source link

Readme addition url based tests #4

Closed eelkeblok closed 6 years ago

eelkeblok commented 6 years ago

Hi,

Thanks a lot for this module. I am currently setting my first steps with Codeception. I'm doing this with a Drupal 7 based project and code some colleagues concocted. One of the components they used is this one.

I have a small PR to make an addition to the README to bridge a gap I experienced with the official CodeCeption documentation. It tries to explain why tests based on Drupal 7 will not include request-based calls (contrary to what the official CC docs emphasise), but still have their use.

I hope you'll consider including it. It would have saved me some time trying to figure out why I didn't see any calls to e.g. $I->amOnPage() 😄

eelkeblok commented 6 years ago

Doesn't look like the tests failed because of a change in this PR.

Chapabu commented 6 years ago

Thanks for this! I'll be honest, I've not looked at this for ages (I moved to Behat for my integration/feature tests) so I'm glad it still works and people are finding a use for it :)

Looks like the tests are failing purely because they run on PHP 5.4, and one of the dependencies doesn't support that anymore. Thanks for flagging it!