Open manonamora opened 2 months ago
This would break support for versions older than 2.36, right? That would be a breaking change for older versions so it's probably best not to change to the new API unless SC removes the old methods completely.
Yeah... it would.
But because 2.37 deprecated Dialog.setup
, it might be nice to have a version for 2.37 as well?
Yeah... it would. But because 2.37 deprecated
Dialog.setup
, it might be nice to have a version for 2.37 as well?
I'm curious, what exactly would be gained by having an additional <<dialog>>
equivalent macro that internally does this...
Dialog.create(title, classes.join(' '));
..instead of this...
Dialog.setup(title, classes.join(' '));
It is future proofed. I guess I could have a separate branch for post-2.37, I'll think about whether I want to do that.
SugarCube 2.37.3 update: switched Dialog.setup for Dialog.create + the wiki on the popup