search

ChapelR / poof

A proofing format for Twine 2.
https://twinelab.net/poof/
The Unlicense
11 stars 0 forks source link

PDF export not working for big stories #5

Closed albuquezi closed 5 years ago

albuquezi commented 5 years ago

When I try to export a big story to PDF (around 8000 words), the PDF gets created but all the pages are blank. I've tried to use both the installed version (Windows) and the online version. Same result.

ChapelR commented 5 years ago

I'll look into this, but it may be a limitation of the canvas, which means it may not get a fast fix. My theory is that large stories wind up being larger than the canvas used to stage the PDF file. Canvases apparently have hard height and width limits of around 32,000 pixels, which I didn't know beforehand. This means that I need to develop some way to read this size and split the file into multiple canvases, then stitch those together into a PDF. Which is gonna be gross.

ChapelR commented 5 years ago

I believe I've fixed this by avoiding using a canvas altogether. An official release with the fix will be forthcoming. Are you able to do some testing for me?

albuquezi commented 5 years ago

Great! Sure! I'll look into this evening and will let you know.

José

A quarta, 3/04/2019, 17:01, Chapel notifications@github.com escreveu:

I believe I've fixed this by avoiding using a canvas altogether. An official release with the fix will be forthcoming. Are you able to do some testing for me?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChapelR/poof/issues/5#issuecomment-479527620, or mute the thread https://github.com/notifications/unsubscribe-auth/Acv39wNwK5ynXvBtueLlvSLVcuNcHZKYks5vdMIlgaJpZM4cUg3r .

ChapelR commented 5 years ago

Just grab the new version from the dist folder.

albuquezi commented 5 years ago

It works fine now. I threw Agnieszka Trzaska’s “Lux” at it

https://ifdb.tads.org/viewgame?id=rg7sieqyg1b9rxpt

which has 55422 words, according to Twine, and I got a 311 page PDF file. So that should mean the solution is robust 😊

And the text is now text and not an image like before, which is better.

Is there any chance to add some PDF config options like choice and size of font or line spacing?

From: Chapel notifications@github.com Sent: 3 de abril de 2019 17:06 To: ChapelR/poof poof@noreply.github.com Cc: albuquezi albuquezi@gmail.com; Author author@noreply.github.com Subject: Re: [ChapelR/poof] PDF export not working for big stories (#5)

Just grab the new version from the dist folder.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChapelR/poof/issues/5#issuecomment-479529928 , or mute the thread https://github.com/notifications/unsubscribe-auth/Acv39x3ZNHP67jG1d3SfDv5ly1WXH37cks5vdMNkgaJpZM4cUg3r . https://github.com/notifications/beacon/Acv3931jSgyS_tr0DOtzePl5AAEjNMx_ks5vdMNkgaJpZM4cUg3r.gif

ChapelR commented 5 years ago

Configuration for the pdf could probably, at least in a limited manner, be added. Probably via poof.config.

About how long did the pdf file take to generate for you? I don't need an exact time or anything, but did it take a few seconds, thirty seconds, a minute?

albuquezi commented 5 years ago

The 8000 words story about 3 seconds (50 PDF pages), and the 55000 words (311 PDF pages ), about 7 seconds. I think it’s quite good.

From: Chapel notifications@github.com Sent: 3 de abril de 2019 19:17 To: ChapelR/poof poof@noreply.github.com Cc: albuquezi albuquezi@gmail.com; Author author@noreply.github.com Subject: Re: [ChapelR/poof] PDF export not working for big stories (#5)

Configuration for the pdf could probably, at least in a limited manner, be added. Probably via poof.config.

About how long did the pdf file take to generate for you? I don't need an exact time or anything, but did it take a few seconds, thirty seconds, a minute?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChapelR/poof/issues/5#issuecomment-479579989 , or mute the thread https://github.com/notifications/unsubscribe-auth/Acv39x7PyeBJIIvI5AfhF4xIC9gwPoaJks5vdOIBgaJpZM4cUg3r . https://github.com/notifications/beacon/Acv397taXhMzwuSc4E7mCf5-BmCuWV7Fks5vdOIBgaJpZM4cUg3r.gif

ChapelR commented 5 years ago

Great, thanks so much for the help!

albuquezi commented 5 years ago

My pleasure! Thank you for doing this for the community!