search

CharaChorder / CCOS-firmware

CharaChorder Operating System
17 stars 1 forks source link

Defect: Compound chord, Right Shift + Enter only sends Enter at an impulse prompt #97

Open duianto opened 2 months ago

duianto commented 2 months ago

Describe the bug

Right Shift + Enter doesn't work at the impulse prompt to switch to the second level in a compound chord. It seems to just send Enter, which overwrites the first chord.

This means that the first chord in the intended compound chord has to be recreated, possibly multiple times if one thought that shift might not have been pressed correctly and attempts it again (multiple times?).

What works

Left Shift + Enter switches to the next compound chord level.

To Reproduce

  1. Open a text editor

  2. Pick two chords to make into a compound chord Warning: The first chord will be overwritten.

  3. For example chord 1: c + d output 1: one chord 2: v + p output 2: two intended compound chord: c + d v + p intended compound output: three

  4. Open the impulse prompt: i + DUP >I<mpulse output:

  5. Type the intended compound output: three

  6. Press: enter >I<mpulse input: v + p

(v + p is shown if it was the last pressed chord)

  1. Press the first chord: c + d >I<mpulse input: c + d

  2. Press right shift + enter

Expected behavior

The impulse promt should change to the second level with a | (vertical bar) after the first chord, and it should show the last pressed chord again, while it's waiting for the second chord to be pressed. >I<mpulse input: c + d | c + d

This is how it works when left shift + enter is pressed in step 8.

Observed behavior

The impulse prompt closes, and the first chord has been overwritten with the intended compound chord. chord 1: c + d output 1: three

Please complete the following information:

Additional context

This was reported on discord: https://discord.com/channels/861730583092658206/938239528454475787/1275589978440859659

Tom: Question. I've just downloaded and installed the beta 2.0 firmware for CC1. Really keen to try the compound chording feature and have a look at the dynamic chord libraries. Device manager has the option for compound chording greyed out and when I try to impulse in a chord using shift enter, I don't have the layer numbers displayed and it doesn't respond to shift enter to add a new layer. Am I doing something wrong? Really confused. Theaninova: The compound chording option has been removed Theaninova: It's just on now Theaninova: The impulse menu is also different now, you will see the complete compound chord instead of the stages with numbers Tom: Ahh, right I see. How do I add compound chords now then? Sorry if this is clearly written somewhere, I can't find it! Tia 😊 Akuma: same as before, actually. Use impulse and definite the first chord, then hit shift + enter. Then you can define the second part Tom: Yeah... that's not working for me by the looks of things. Any ideas? Akuma: hm i’m confused. It definitely works for me, even though compound chording shows greyed out and in off state in the manager. Are you sure you are on the 2.0.0-beta? And you are not trying to use Enter on another layer than the first? Tom: I've just figured the issue. It's because I was trying to use right shift and enter. It only works with left shift