Since dist.py is meant to "setup" the project locally or to build it, it makes sense for it to generate files that may not exist in the repository (such as nexus/ui/BanlistDialog.py, etc.). However, it doesn't make sense to "update" existing files to match the code. This is because the code itself is expected to be up-to-date.
So, running pyside6-lupdate in dist.py either does nothing (if the files are up-to-date) or they update them to be accurate (this is bad since it means the file in repo is outdated)
Solution
I can think of 2 solutions:
Don't track the translation files in Git and let them be generated by lupdate
Don't update in dist.py, instead maybe do it exclusively in the pre-commit hook
Option 1 is less than ideal, since I suppose there are some manually defined things within those files.
https://github.com/CharaChorder/nexus/blob/3e6d11fa2721219835556ec1eb2e5e7f1898e100/dist.py#L69-L72 This code essentially updates the
i18n_en.tsfile.Since
dist.pyis meant to "setup" the project locally or to build it, it makes sense for it to generate files that may not exist in the repository (such asnexus/ui/BanlistDialog.py, etc.). However, it doesn't make sense to "update" existing files to match the code. This is because the code itself is expected to be up-to-date.So, running
pyside6-lupdateindist.pyeither does nothing (if the files are up-to-date) or they update them to be accurate (this is bad since it means the file in repo is outdated)Solution
I can think of 2 solutions:
lupdatedist.py, instead maybe do it exclusively in the pre-commit hookOption 1 is less than ideal, since I suppose there are some manually defined things within those files.