search

Charca / bootbot

Facebook Messenger Bot Framework for Node.js
MIT License
974 stars 253 forks source link

add typings #114

Closed adityapurwa closed 10 months ago

adityapurwa commented 6 years ago

Added typescript typings so typescript user can use this library with ease.

davidfrtala commented 6 years ago

Any update on this?

adityapurwa commented 6 years ago

@davidfrtala Just waiting for @Charca to confirm on this, I personally used TypeScript extensively and having typings would help me .

davidfrtala commented 6 years ago

@adityapurwa have you also updated the typings for most recent version? There are also some issues from what I see. For instance in SendApi class declaration, most of the send* functions returns void which is wrong, because they call sendRequest() and returns a Promise.

adityapurwa commented 6 years ago

@davidfrtala Not yet, thanks for tellling me! Will update it when I have time.

Charca commented 6 years ago

Thanks for the PR @adityapurwa. This looks good to me, but I honestly don't have a lot of experience with TypeScript so I'm probably not the best person to comment on it.

But this doesn't conflict with anything, so if you give me a 👍 I'll merge this in.